systemtest: fix missing error check #4683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4683 +/- ##
=======================================
Coverage 76.16% 76.16%
=======================================
Files 161 161
Lines 9873 9873
=======================================
Hits 7520 7520
Misses 2353 2353
|
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Steps errors
Expand to view the steps failures
|
|
Trivial fix, merging without review. |
axw
added a commit
to axw/apm-server
that referenced
this pull request
Feb 19, 2021
axw
added a commit
to axw/apm-server
that referenced
this pull request
Feb 19, 2021
axw
added a commit
that referenced
this pull request
Feb 19, 2021
…: fix missing error check (#4683) | systemtest: compensate for Fleet API bug (#4693) (#4832) * systemtest: test apm-server in Fleet mode (#4650) * systemtest: test apm-server in Fleet mode We run a custom package registry into which the "apm" integration package is bind-mounted from the tree, enabling us to test with unreleased package changes. Add a system test that runs Elastic Agent in Fleet mode, with a locally built APM Server binary injected into the container. The test adds the "apm" integration package to a new agent policy, waits for elastic-agent to start apm-server, and verifies it is functional. # Conflicts: # systemtest/elasticsearch.go * systemtest: fix missing error check (#4683) * systemtest: compensate for Fleet API bug (#4693) * systemtest: compensate for Fleet API bug elastic/kibana#90544 is causing the system test to respond with 404 Not Found, despite the policy existing and being successfully deleted. Update the test to temporarily expect a 404 response to avoid failing all our builds. Once the Kibana bug is resolved this will start failing, and we can again check that no error is returned.
axw
added a commit
that referenced
this pull request
Feb 20, 2021
… fix missing error check (#4683) | systemtest: compensate for Fleet API bug (#4693) (#4831) * systemtest: test apm-server in Fleet mode (#4650) * systemtest: test apm-server in Fleet mode We run a custom package registry into which the "apm" integration package is bind-mounted from the tree, enabling us to test with unreleased package changes. Add a system test that runs Elastic Agent in Fleet mode, with a locally built APM Server binary injected into the container. The test adds the "apm" integration package to a new agent policy, waits for elastic-agent to start apm-server, and verifies it is functional. # Conflicts: # systemtest/elasticsearch.go * systemtest: fix missing error check (#4683) * systemtest: compensate for Fleet API bug (#4693) * systemtest: compensate for Fleet API bug elastic/kibana#90544 is causing the system test to respond with 404 Not Found, despite the policy existing and being successfully deleted. Update the test to temporarily expect a 404 response to avoid failing all our builds. Once the Kibana bug is resolved this will start failing, and we can again check that no error is returned.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
Check error in test to avoid surprises later on.
How to test these changes
cd systemtest && go test -v -run FleetRelated issues
None.